feat: Add catalog-based material presets across structural nodes#231
Merged
open-pascal merged 3 commits intopascalorg:mainfrom Apr 15, 2026
Merged
Conversation
sudhir9297
changed the title
open-pascal
reviewed
Apr 15, 2026
Collaborator
open-pascal
left a comment
open-pascal
left a comment
There was a problem hiding this comment.
Rechecked the follow-up commits against the two regressions I called out earlier.
- The door/window material panel is no longer blank:
MaterialPickernow keeps a custom fallback even when there are no catalog items. - Visible wall selection/delete highlighting is restored in
wall-cutout.tsx, and the highlighted variants now preserve the underlying wall material/preset appearance.
So the two blockers from my earlier review look addressed from my side. One smaller note remains: door/window are effectively custom-only now, instead of exposing the old preset swatches, but that is separate from the blank-state regression I flagged.
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a shared, catalog-based material ( 13 items ) preset system across
wall,slab,roof,roof-segment,stair,stair-segment,ceiling, andfence.Key updates:
custommaterial fallbacklibrary:<id>maps + mapPropertiesRendering/runtime fixes: